Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config panel to recorder #11002

Closed
wants to merge 3 commits into from

Conversation

sanyatuning
Copy link

@sanyatuning sanyatuning commented Dec 22, 2021

Proposed change

Add configuration screen to recorder integration.
core PR: home-assistant/core#62604

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@sanyatuning sanyatuning changed the title Add config panel to recorder WIP: Add config panel to recorder Dec 22, 2021
@spacegaier
Copy link
Member

Just wondering whether a panel is the correct approach here or whether this should be a config flow from the backend for the recorder integration?

@sanyatuning sanyatuning marked this pull request as draft December 22, 2021 15:42
@sanyatuning
Copy link
Author

Just wondering whether a panel is the correct approach here or whether this should be a config flow from the backend for the recorder integration?

Is it possible to show an "entities picker" in the config/options flow?

@sanyatuning sanyatuning marked this pull request as ready for review January 1, 2022 20:28
@spacegaier
Copy link
Member

spacegaier commented Jan 2, 2022

Just wondering whether a panel is the correct approach here or whether this should be a config flow from the backend for the recorder integration?

Is it possible to show an "entities picker" in the config/options flow?

Can't remember having ever seen that, but that doesn't mean it's not possible :) .

EDIT: With a quick glance at the coding, I cannot see a ha-form-entity-picker.ts or similar.

@matthiasdebaat
Copy link
Collaborator

Like that recorder settings can be changed in the UI. Don't want to scope creep, but should this be an entity setting in the dialog instead of a big recorder setting?

@sanyatuning
Copy link
Author

@matthiasdebaat
That will be a great addition but requires changing the core entity classes (I tried it), and in the first step, I would like to introduce something much simpler but useful.

@sanyatuning sanyatuning changed the title WIP: Add config panel to recorder Add config panel to recorder Jan 3, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 18, 2022
@zsarnett
Copy link
Contributor

Core PR still WIP

@github-actions github-actions bot removed the stale label Apr 18, 2022
@zsarnett zsarnett marked this pull request as draft April 20, 2022 03:15
@dougiteixeira
Copy link

Like that recorder settings can be changed in the UI. Don't want to scope creep, but should this be an entity setting in the dialog instead of a big recorder setting?

Just one point: it really seems ideal that the configuration was carried out in the settings of each entity. But there should be a way to change this in bulk, maybe some services like "include all entities in recorder", "exclude all entities in recorder", "include entities listed in recorder", "exclude entities listed in recorder", maybe with domains too… this would avoid the user having to manipulate the configuration of each entity of the instance (which sometimes are many) to configure the recorder. The same goes for a panel, it would be nice to have an option to select the entities and include or exclude them in the bulk recorder.

@zsarnett
Copy link
Contributor

Backend Closed

@zsarnett zsarnett closed this Jul 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants