Add link flags for grpc armv7 wheels #62779
Conversation
Add missing flags so that we can link grpc armv7 builds. This is needed because home assistant wheel building installs libexecinfo which grpc recognizes and uses for `backtrace`. This is normally provided by the standard library but is not provided by alpine / musl. This allows building a grpc 1.43.0 wheel on alpine 3.14 armv7 with python 3.9
|
Would it be better for me to create a separate project for building wheels for GRPC like we did for tensorflow and apply a patch directly to the source? It basically need something like this: The build can take awhile, but probably not as long as tensor flow, so I had to build my only little harness for building this, so it could effectively be converted into a Dockerfile |
|
Thinking about this more, i think it might be simpler to just separate grpc wheel building? It seems like "pip wheel" may work just fine without a patch if we just use build environment that does not include libexecinfo-dev. |
frenck
added
the
smash
Yes, similarly, if we remove 3.8 then everyone will be building grpcio from source without a wheel. |
This reverts commit 0945692.
Proposed change
Add
-lexecinfoto the list of GRPC LDFLAGS, which allows the home assistant wheel builder to create wheels for armv7 grpc builds.This is needed because:
libexecinfo-devin the builderbacktraceas part of the system library, however it can come from `-lexecinfoThis allows building a grpc 1.43.0 wheel on armv7 alpine 3.14 with python 3.9
GRPC currently does not have a way to add a single LDFLAG, so the existing LDFLAGS are copied until an option for that is added, which I can explore.
I would like to discuss how we can best test this and upgrade grpc. My concern: when the wheels are not in place it will build from source which can take a really long time and will be killed by the supervisor. So ,I think we need to build all the wheels first before bumping up to 1.43.0. Would like to discuss any other testing that would be helpful for me to do.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: