Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Senseme #62901

Closed
wants to merge 2 commits into from
Closed

Senseme #62901

wants to merge 2 commits into from

Conversation

mikelawrence
Copy link
Contributor

@mikelawrence mikelawrence commented Dec 28, 2021

Proposed change

Adds integration for Haiku with SenseME Fans. This integration has been available in HACS for a while but I'm not able to continue supporting this integration. Luckily @bdraco has agreed to take this PR and integrate it with HA.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member

bdraco commented Dec 28, 2021

Thanks @mikelawrence

I'm going to start a fresh PR to merge one platform at a time using this as a base.

@bdraco bdraco marked this pull request as draft December 28, 2021 00:56
@mikelawrence
Copy link
Contributor Author

Sounds great!

@bdraco
Copy link
Member

bdraco commented Jan 20, 2022

Everything is merged so I'm going to close this now.

Thanks Mike!

@bdraco bdraco closed this Jan 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants