Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SenseME integration #62909

Merged
merged 20 commits into from Jan 8, 2022
Merged

Add SenseME integration #62909

merged 20 commits into from Jan 8, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 28, 2021

Proposed change

Add SenseME integration

This is a reduced version of #62901 to merge one platform at a time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@bdraco
Copy link
Member Author

bdraco commented Dec 28, 2021

TODO

  • Docs
  • Finish config flow tests
  • Move the brands image

@bdraco bdraco changed the title Add SenseME fan integration Add SenseME integration Dec 28, 2021
@bdraco bdraco marked this pull request as ready for review December 28, 2021 08:40
@ctalkington ctalkington self-requested a review January 7, 2022 05:55
Copy link
Contributor

@ctalkington ctalkington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

Dev automation moved this from Needs review to Reviewer approved Jan 8, 2022
@bdraco
Copy link
Member Author

bdraco commented Jan 8, 2022

Thanks. There was a lot of legacy here. I think I've got everything up to modern standards 馃

I'll start working on cleanup up the next platform.

@bdraco bdraco merged commit 943aaae into home-assistant:dev Jan 8, 2022
Dev automation moved this from Reviewer approved to Done Jan 8, 2022
@bdraco bdraco deleted the senseme_split branch January 8, 2022 08:53
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants