-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tuya data type information in climate #62994
Conversation
Hey there @tuya, @zlinoliver, @METISU, mind taking a look at this pull request as it has been labeled with an integration ( |
This did not resolve the climate issue for the eurom heater issues merged. :-(. Logger: homeassistant.components.climate Error while setting up tuya platform for climate |
This is a PR, which is closed and handled. If you experience an issue, please create an issue report. |
thanks for the response, im not sure how. anyways the problem isnt solved for the eurom heaters( tuya api) so I would think the issues that are closed can be re opened? |
No, please create a new issue in the issue tracker an provide as much information as possible about the issue you are experiencing. Thanks 👍 |
Proposed change
Similar to #62993, but for climate
The Tuya API provides functions definitions and status_ranges; These are a bit of the same and most often mixed up (which origins are already in the original Tuya V2 custom integration).
Looking at the specs, the issues reported and the upstream client code, we should use the type description from the function instead of the status range when we are using an exposed/changeable functionality.
This PR adjusts it for the climate entities.
Tested against two heaters I have locally, to verify those still work as expected.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: