Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google-cloud-pubsub to 2.9.0 (attempt #3) #63911

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Jan 11, 2022

Third attempt of PR #63493, #63522 to kick off grpcio wheel build.

Once this runs, we'll watch the actions to ensure grpcio is built correctly.

Additional fixes from first attempt:

Related to issue #55883, #56669, #59516

Original PR description below:

The primary motivation is to kick off building wheels for grpcio, however there are also many pub/sub related bug fixes since 2.1.0 in September 2020.

googleapis/python-pubsub@v2.1.0...v2.9.0 where notable changes include Graceful streaming pull shutdown (desired by nest and should help with #63206) and flow control improvements.

This also implicitly pulls in GRPC, which has been behind since Aug 2020.
grpc/grpc@v1.31.0...v1.43.0

I've manually tested this with:

  • Publisher client: Tested via google_pubsub
  • Subscriber client: Tested via nest
  • I've been using latest versions of grpcio for local development testing of google-nest-sdm for the past year

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go again 👍 🙏

@frenck frenck merged commit aab5a09 into dev Jan 11, 2022
@frenck frenck deleted the revert-63561-revert-63522-cloud-pubsub-bump branch January 11, 2022 16:25
@allenporter
Copy link
Contributor Author

I forgot to request that you wipe the existing armv7 wheel! (created on Jan 6th which was not built from source) argh

@frenck frenck mentioned this pull request Jan 11, 2022
27 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants