Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pytradfri to 8.0.1 and fix fan preset mode "Auto" bug #63920

Merged
merged 12 commits into from
Jan 14, 2022

Conversation

ggravlingen
Copy link
Contributor

@ggravlingen ggravlingen commented Jan 11, 2022

Breaking change

Proposed change

This PR:

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@epenet
Copy link
Contributor

epenet commented Jan 11, 2022

Are the code changes compulsory in this PR?
Or could they be a followup PR to the dependency bump?

@ggravlingen
Copy link
Contributor Author

ggravlingen commented Jan 11, 2022

@epenet the changes to fan.py are required as the API in the dependecy has changed. The changes to the util functions are required too. Moving the error-handler to the util-file is not required though. I argued with myself if I was going to do that but since I was refactoring util functions it made sense to move that one too. Happy to put it back if it makes review easier.

@ggravlingen ggravlingen marked this pull request as ready for review January 11, 2022 20:01
@ggravlingen ggravlingen changed the title Bump pytradfri to 8.0.1 Bump pytradfri to 8.0.1 and fix fan preset mode "Auto" bug Jan 11, 2022
homeassistant/components/tradfri/fan.py Outdated Show resolved Hide resolved
tests/components/tradfri/test_util.py Outdated Show resolved Hide resolved
tests/components/tradfri/test_util.py Outdated Show resolved Hide resolved
tests/components/tradfri/test_util.py Outdated Show resolved Hide resolved
ggravlingen and others added 4 commits January 13, 2022 18:07
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you testing the PR with a real device?

homeassistant/components/tradfri/fan.py Outdated Show resolved Hide resolved
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@ggravlingen
Copy link
Contributor Author

Are you testing the PR with a real device?

I have been running this in my custom component. Apologies, I felt this PR became a bit sloppy when I moved the code into the core base. Will try to do better.

@MartinHjelmare
Copy link
Member

Ok. Please test the code in the PR with a real device before we merge.

@ggravlingen
Copy link
Contributor Author

image

@ggravlingen
Copy link
Contributor Author

image

@ggravlingen
Copy link
Contributor Author

image

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit b52a8ba into home-assistant:dev Jan 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2022
@ggravlingen ggravlingen deleted the tradri801 branch January 15, 2022 07:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starkvind preset mode Auto doesnt stick
4 participants