-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netgear try all ports #64170
Netgear try all ports #64170
Conversation
Hey there @hacf-fr, @Quentame, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the CI.
If we're going to try it all, we should just stop asking port. |
Also order the ports in the order defaults on newer models -> older models, then configured other ports (SSL etc) on newer models -> older models. |
Actually the director of software engineering from Netgear recommended me to first try the SSL ports and then the ports withouth SSL. |
@balloob could you give me permission on pypi to upload to the pynetgear project? |
Done |
@starkillerOG I am in pypi to do so, what's your handle please ? |
My user name is StarkillerOG, what do you mean with handle? |
@MatMaul this is my profile page: https://pypi.org/user/StarkillerOG/ |
Thank you so much @MatMaul, I just uploaded the new 0.9.0 release to pypi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments in a new PR. Thanks!
Proposed change
During config_flow and setup, try all known Netgear ports (5555 and 433 with SSL and 5000 and 80 without SSL).
The port and SSL option given in the config_entry will be the first one that will be attempted, if that fails the other 3 will be tried, if all fail ConfigEntryNotReady will be raised.
On a succesfull connection, the port and SSL will be updated in the config_entry (if they have changed).
This process was recomended by the director of software engineering from Netgear.
According to him that schould work with all Netgear routers and across firmware upgrades.
Motivation for this change is that on the most recent firmware of the popular Netgear R7000 router the port has changed from 5000 to 5555, this has already been fixed for this specific model in PR #64012, but this will ensure a more future proof method that will work for all models.
Also bumps pynetgear version to 0.9.0:
MatMaul/pynetgear@0.8.0...0.9.0
NOTE: PYNETGEAR VERSION 0.9.0 STILL NEEDS TO BE UPLOADED TO PYPII (StarkillerOG) still need to get acces rights from eather @MatMaul or @balloob see MatMaul/pynetgear#90 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: