Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove myself from CODEOWNERS #64188

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

Noltari
Copy link
Contributor

@Noltari Noltari commented Jan 16, 2022

Proposed change

Every new PR takes too long to be accepted unless you are a core member, in
that case they are normally accepted in a reasonable period of time.
I hope this changes in the future, until then I will be a simple user of the
project because I don't have enough free time to face this.
Apparently, in order to have your PRs accepted in a reasonable period of time
you need to dedicate yourself fully to the project, but as you may know, I
eat because they pay me for doing my job, not for contributing to HA.

More info: #58053

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Every new PR takes too long to be accepted unless you are a core member, in
that case they are normally accepted in a reasonable period of time.
I hope this changes in the future, until then I will be a simple user of the
project because I don't have enough free time to face this.
Apparently, in order to have your PRs accepted in a reasonable period of time
you need to dedicate yourself fully to the project, but as you may know, I
eat because they pay me for doing my job, not for contributing to HA.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
@probot-home-assistant
Copy link

Hey there @michaelarnauts, mind taking a look at this pull request as it has been labeled with an integration (tado) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions thus far, @Noltari 👍

@frenck frenck merged commit ea96e7e into home-assistant:dev Jan 16, 2022
@frenck frenck mentioned this pull request Jan 16, 2022
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2022
@Noltari Noltari deleted the project-development-leave branch March 18, 2022 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants