Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webostv YAML migration failure if the entity is removed #64290

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

thecode
Copy link
Member

@thecode thecode commented Jan 17, 2022

Proposed change

Fix webostv YAML migration failure if the entity is removed before the TV is online.
At startup we check if there are entities to be migrated and wait for a connection with the device. Since this process can be very long, the user can delete the entities or do a new paring with the TV, this PR adds a check again before we do the actual unique id update to make sure the entity is still available.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bendavid, mind taking a look at this pull request as it has been labeled with an integration (webostv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thecode thecode merged commit 57bd8a7 into home-assistant:dev Jan 17, 2022
@thecode thecode deleted the fix-webostv-import branch January 17, 2022 17:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration from configuration.yaml WebOSTV fails when loading the new integration version
4 participants