Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to KNX #64471

Merged
merged 2 commits into from
Jan 19, 2022
Merged

Add diagnostics to KNX #64471

merged 2 commits into from
Jan 19, 2022

Conversation

farmio
Copy link
Contributor

@farmio farmio commented Jan 19, 2022

Proposed change

Add diagnostics to KNX

An example of the output would be:

{
    "home_assistant": {
        "installation_type": "Home Assistant Core",
        "version": "2022.2.0.dev0",
        "dev": true,
        "hassio": false,
        "virtualenv": true,
        "python_version": "3.9.7",
        "docker": false,
        "arch": "arm64",
        "timezone": "UTC",
        "os_name": "Darwin",
        "os_version": "12.1",
        "user": "farmio"
    },
    "xknx": {
        "version": "0.18.16.dev",
        "current_address": "1.0.255"
    },
    "config_entry_data": {
        "state_updater": true,
        "rate_limit": 20,
        "individual_address": "15.15.250",
        "multicast_group": "224.0.23.12",
        "multicast_port": 3671,
        "connection_type": "tunneling",
        "local_ip": null,
        "host": "10.1.0.40",
        "port": 3671,
        "route_back": false
    },
    "configuration_yaml": {
        "light": [
            {
                "name": "K\u00fcche Esstisch",
                "address": "1/1/45",
                "state_address": "1/0/45"
            }
        ]
    },
    "configuration_error": null
}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jan 19, 2022
@balloob
Copy link
Member

balloob commented Jan 19, 2022

ok to merge after adding a test or exclude file coverage

@balloob balloob merged commit 10538aa into home-assistant:dev Jan 19, 2022
Copy link
Contributor

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine locally!

@farmio farmio deleted the knx-diagnostics branch January 19, 2022 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2022
Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address these comments i a new PR

) -> dict:
"""Return diagnostics for a config entry."""
diag: dict[str, Any] = {}
diag["home_assistant"] = await async_get_system_info(hass)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hass system info is added central with #64670, so it can be removed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: knx new-feature smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants