Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miio push server #64726

Closed
wants to merge 36 commits into from
Closed

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jan 22, 2022

Breaking change

Proposed change

Add a push server for the xiaomi miio integration.
This allows for local pushes instead of only polling and will allow for the support of a lot more zigbee devices such as:

  • motion sensors
  • door sensors
  • buttons
  • remote_switches
  • wall_switches
  • cubes
  • vibration sensors

NOTE: A NEW VERSION OF PYTHON-MIIO NEEDS TO BE RELEASED FIRST
The PR for this is here: rytilahti/python-miio#1446 and rytilahti/python-miio#1459

The required upstream changes have been included in HomeAssistant in a version bump of python miio here: #75415

To do:

  • make documentation: list al newly supported device.
  • add extra tests

This has already been tested locally using 2 gateways simultaniously and it worked butifully.

This requires upstream library PR: rytilahti/python-miio#1521

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 22, 2022
@frenck frenck marked this pull request as draft January 23, 2022 16:07
@frenck frenck changed the title W.I.P. Miio push server Miio push server Jan 23, 2022
@frenck
Copy link
Member

frenck commented Jan 23, 2022

Marked as draft (instead of W.I.P)

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 23, 2022
@starkillerOG starkillerOG mentioned this pull request Sep 12, 2022
22 tasks
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare could you approve this PR or do you have any more feedback?
Note that the upstreams lib needs a new version release before merging this.

@MartinHjelmare MartinHjelmare marked this pull request as draft September 12, 2022 09:05
@jazomand
Copy link

jazomand commented Oct 6, 2022

@MartinHjelmare whats the process normally to have a PR merged and released on this project?
This PR is exactly what I need and I could fix any remaining issues if there is a need.

@MartinHjelmare MartinHjelmare added the waiting-for-upstream We're waiting for a change upstream label Oct 6, 2022
@MartinHjelmare
Copy link
Member

This PR is draft as it's waiting for a library release and bump as you can read above.

@starkillerOG
Copy link
Contributor Author

@jazomand the upstream PR has already been merged in the dev branch of python-miio, but we are waiting on a new release of python-miio before this can move allong.
I suspect we can make HomeAssistant 2022.11, but it depends on when @rytilahti has time for the python-miio release.

@jazomand
Copy link

jazomand commented Oct 7, 2022

Oh I see. I saw it merged on miio and thought everything was ready, but you are right. The release is not out yet.
Thanks @starkillerOG @MartinHjelmare for explaining and for everything.

@bieniu bieniu removed their request for review November 24, 2022 21:14
@bieniu bieniu removed their assignment Nov 24, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 22, 2023
@starkillerOG
Copy link
Contributor Author

Still waiting for upstream

@github-actions github-actions bot removed the stale label Feb 23, 2023
@MartinHjelmare
Copy link
Member

I suggest closing here until upstream is ready.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 17, 2023
@github-actions github-actions bot closed this Aug 24, 2023
Dev automation moved this from By Code Owner to Cancelled Aug 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

8 participants