-
-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use asyncio facilities for push server where possible #1521
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1521 +/- ##
==========================================
- Coverage 82.15% 82.13% -0.02%
==========================================
Files 145 145
Lines 14161 14164 +3
Branches 3416 3416
==========================================
Hits 11634 11634
- Misses 2302 2305 +3
Partials 225 225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rytilahti I tested this and everything still works. Can you merge this? |
@rytilahti could you please merge this so I can move allong with PR home-assistant/core#64726? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on surface and it is much better this way, so let's get this merged. Thanks! 👍
@rytilahti thanks a lot! |
I'm currently on holidays so I'm not feeling comfortable creating a new release just right now, especially as the current code base contains lot of changes related to #1495 that should be tested also on other devices that I have in my possession. I'll try to find some time to review the related homeassistant PR soon though :-) |
Make the push server fully async by avoiding using executors when not necessary.
As required by home-assistant/core#64726