Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complementing the Tuya Fan (fs) category #64947

Merged
merged 7 commits into from
Jan 26, 2022
Merged

Complementing the Tuya Fan (fs) category #64947

merged 7 commits into from
Jan 26, 2022

Conversation

dougiteixeira
Copy link
Contributor

Proposed change

This PR complements the Fan (fs) category with resources available in Tuya's documentation that are not part of the fan entity.

Code Name Data type Value constraint
fan_vertical Vertical swing flap angle Enum {“range”:[“30”,“60”,“90”]}
fan_horizontal Horizontal swing flap angle Enum {“range”:[“30”,“60”,“90”]}
anion Anion Boolean {}
humidifier Humidification Boolean {}
oxygen Oxygen bar Boolean {}
fan_cool Cool wind Boolean {}
fan_beep Sound Boolean {}
child_lock Child lock switch Boolean {}
light Light switch Boolean {}
bright_value Brightness value Integer {“min”:10,“max”:1000,“scale”:0,“step”:1}
temp_value Temperature value Integer {“min”:0,“max”:1000,“scale”:0,“step”:1}
work_mode Light mode Enum {“range”:[“white”,“colour”,“colourful”]}
temp Temperature setting Integer {“unit”:“℃”,“min”:0,“max”:50,“scale”:0,“step”:1}
*countdown Countdown Enum {“range”:[“0”,“1”,“2”,“3”,“4”,“5”,“6”]}
countdown_set Countdown setting Enum {“range”:[“cancel”,“1h”,“2h”,“3h”,“4h”,“5h”,“6h”]}

Not tested with a device as there is no virtual Fan device available.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @tuya, @zlinoliver, @METISU, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@dougiteixeira dougiteixeira marked this pull request as ready for review January 26, 2022 02:58
homeassistant/components/tuya/select.py Outdated Show resolved Hide resolved
homeassistant/components/tuya/strings.select.json Outdated Show resolved Hide resolved
homeassistant/components/tuya/switch.py Outdated Show resolved Hide resolved
homeassistant/components/tuya/switch.py Outdated Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dougiteixeira 👍

@frenck frenck merged commit 982580b into home-assistant:dev Jan 26, 2022
@dougiteixeira dougiteixeira deleted the tuya-fs branch January 26, 2022 12:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tuya ceiling fan - does not support light
4 participants