Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqara restore door sensor state on start #65128

Merged

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jan 28, 2022

Breaking change

Proposed change

On HA 2022.02 dev the aqara door sensors will start with state "unknown" instead of the last known state before the HomeAsstant restart as it was before.
For Door/Window sensors it makes sence to just restore the last known state.
Especially if it consernes window sensors that for instance will not be opend during the winter, the state will stay on unknown the whole winter, which is not desireable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Danielhiversen, @syssi, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_aqara) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@starkillerOG
Copy link
Contributor Author

Ready for revieuw/merge.
Note that this schould be merge to the 2022.02.dev branch.

@piio
Copy link

piio commented Jan 28, 2022

I hit this problem after updating to 2022.02.0b0 and 2022.02.0b1 - my Aquara door/windows and leak sensors after restart goes to 'unknown' state until any action with that sensors which triggers state change. On Xiaomi Home state is correct.
After implementing this change my door/window sensor shows last state, but I see still this problem with leak sensor.

@starkillerOG
Copy link
Contributor Author

@piio the latest commit schould also fix Natgas, WaterLeak and Smoke sensors.
Could you try it out?

@piio
Copy link

piio commented Jan 28, 2022

@starkillerOG Hi, I just checked - my water leak sensor is no more in 'unknown' state, it shows last sensor state.
I don't have another types of sensor, so I can't check nothing more, but door/window sensor and water leak looks ok now for me, thank you very much.

@starkillerOG
Copy link
Contributor Author

@MartinHjelmare could you add this to the 2022.02 milestone?
It is a bug intruduced in 2022.2.0b0

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare added this to the 2022.2.0 milestone Jan 29, 2022
@MartinHjelmare MartinHjelmare merged commit 8bd7519 into home-assistant:dev Jan 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants