Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiowebostv to 0.1.2 #65267

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Conversation

thecode
Copy link
Member

@thecode thecode commented Jan 30, 2022

Proposed change

Bump aiowebostv to 0.1.2

Changlog:

  • Bump version to 0.1.2 (@thecode)
  • Replace ping task with websockets ping task (@thecode)

Diff: home-assistant-libs/aiowebostv@v0.1.1...v0.1.2

This should resolve #43492, some suggested that #49453 is also related the changes to resolve connection issues:

  • Remove the ping task and replace it with websockets internal ping task.
    There are few users (mostly in isolated VLAN) that complained that TCP connections to the device never close.
    When the TCP connection doesn't close the disconnect never happens and client stays in a connected state although it is not connected.
  • Update the ping interval from 1 to 5 as 1 seems very low value. I have no data to understand why such high ping interval is needed. Tests with two users and myself showed no problems with setting this to 5.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bendavid, mind taking a look at this pull request as it has been labeled with an integration (webostv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@thecode thecode merged commit 5999d08 into home-assistant:dev Jan 30, 2022
@thecode thecode deleted the bump-aiowebostv branch January 30, 2022 22:04
balloob pushed a commit that referenced this pull request Jan 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LG webOS TV not (always) detected after being powered off unless HA is restarted/log spamming
4 participants