Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanup in Plugwise switch #65845

Merged
merged 1 commit into from Feb 6, 2022
Merged

Small cleanup in Plugwise switch #65845

merged 1 commit into from Feb 6, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Feb 5, 2022

Proposed change

Small cleanup of the Plugwise switch platform. Mostly typing and the use of shorthand attributes.

This is part of a cleanup effort, to minimize and type the integration, so much needed upgrades to become possible (e.g., the library that now has conflicts)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Feb 5, 2022
@probot-home-assistant
Copy link

Hey there @CoMPaTech, @bouwew, @brefra, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck
Copy link
Member Author

frenck commented Feb 5, 2022

Rebased to deal with the merge conflict

Dev automation moved this from Needs review to Reviewer approved Feb 5, 2022
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@frenck
Copy link
Member Author

frenck commented Feb 6, 2022

Rebased to deal with a merge conflict

@frenck frenck merged commit a0895f1 into dev Feb 6, 2022
Dev automation moved this from Reviewer approved to Done Feb 6, 2022
@frenck frenck deleted the frenck-2022-0320 branch February 6, 2022 09:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants