Improve code quality season #66449
Merged
Improve code quality season #66449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davet2001
requested changes
Feb 14, 2022
| self.datetime = utcnow().replace(tzinfo=None) | ||
| self.season = get_season(self.datetime, self.hemisphere, self.type) | ||
| self._attr_native_value = get_season( | ||
| utcnow().replace(tzinfo=None), self.hemisphere, self.type |
There was a problem hiding this comment.
This replicates the existing behaviour, so no new problem.
It might not be critical to know the precise start of a season to the nearest hour, but won't using utcnow() mean that the season transitions when the utc timezone enters the season rather than the local timezone?
There was a problem hiding this comment.
Yeah, that is actually an existing issue I would say
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Code quality season
Typing, cleaning
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: