Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move key sequences to bridge in SamsungTV #67762

Merged
merged 6 commits into from
Mar 8, 2022

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 6, 2022

Proposed change

Currently, key sequences are handled inside media_player, with a sleep in between each key.
However, this timer is also already part of the websocket library, so it should be kept only for the legacy bridge.

Note: currently, only async_play_media uses key sequences (eg. 5 + 7 + 6 + ENTER to set channel 576) but new sequences will be added in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @escoand, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@epenet epenet changed the title Move key sequences to bridge Move key sequences to bridge in SamsungTV Mar 6, 2022
@bdraco
Copy link
Member

bdraco commented Mar 6, 2022

I'm traveling so I can't test until next week.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 7, 2022
@bdraco
Copy link
Member

bdraco commented Mar 8, 2022

Updated my instance remotely and tested. Couldn't verify in person, but it seems to work as expected. Will do manual testing later this week and message on discord if I find an issue.

@bdraco bdraco merged commit 1793c29 into home-assistant:dev Mar 8, 2022
@epenet epenet deleted the samsungtv-sequences branch March 8, 2022 06:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants