Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flow for derivative sensor #68268

Merged
merged 3 commits into from
Mar 18, 2022
Merged

Add config flow for derivative sensor #68268

merged 3 commits into from
Mar 18, 2022

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Mar 16, 2022

Proposed change

Add config flow for derivative sensor

Overriding the source sensor's unit is not supported, background here: #68288 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @afaucogney, mind taking a look at this pull request as it has been labeled with an integration (derivative) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@emontnemery emontnemery requested a review from a team as a code owner March 17, 2022 12:41
@frenck frenck marked this pull request as draft March 17, 2022 18:26
@frenck
Copy link
Member

frenck commented Mar 17, 2022

Marked it draft, awaiting #68267

@emontnemery emontnemery marked this pull request as ready for review March 18, 2022 09:29
@emontnemery emontnemery reopened this Mar 18, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @emontnemery 👍 Looks good and works well 👍

@frenck frenck merged commit 5bb271c into dev Mar 18, 2022
@frenck frenck deleted the derivative_config_flow branch March 18, 2022 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2022
@frenck frenck added noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) config-flow This integration migrates to the UI by adding a config flow labels Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow has-tests integration: derivative new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants