Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort samsungtv discovery of legacy devices when unique id not available #69376

Merged
merged 1 commit into from Apr 5, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 5, 2022

Proposed change

Fixes #69374

  • The legacy devices have no rest api to compare the UDN
    against to ensure we have the one we use for the unique id

  • We still need to proceed through the first part of the
    discovery to ensure we update any url if the device
    is already configured

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Fixes home-assistant#69374

- The legacy devices have no rest api to compare the UDN
  against to ensure we have the one we use for the unique id

- We still need to proceed through the first part of the
  discovery to ensure we update any url if the device
  is already configured
@bdraco bdraco added this to the 2022.4.0 milestone Apr 5, 2022
@project-bot project-bot bot added this to Needs review in Dev Apr 5, 2022
@probot-home-assistant
Copy link

Hey there @chemelli74, @epenet, mind taking a look at this pull request as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Apr 5, 2022
@balloob balloob merged commit 4b5033d into home-assistant:dev Apr 5, 2022
Dev automation moved this from Reviewer approved to Done Apr 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Samsung TV duplicate discovery
5 participants