Improve typing of deCONZ diagnostics

[Kane610]

Breaking change

Proposed change

• Check web socket is initialised

homeassistant/components/deconz/diagnostics.py:28: error: Item "None" of "Optional[WSClient]" has no attribute "state"  [union-attr]

Full typing was done here #58968 and part of it split out to this PR.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[davet2001]

The code changes look good to me.

The title of the PR doesn't seem to fit the change?

I assume that there are either no collisions merging these dicts or that the collisions don't matter. Is that true?

[Kane610]

Isn't the PR improving the typing of deconz diagnostics platform? :)

Exactly. The end result should look the same. There are no duplication of data between those different classes as the data will only be put into one of them

[davet2001]

I suppose I was looking for type hints etc. But yes I suppose so!

[Kane610]

Thanks @davet2001

[chishm]

This is a case where maintainability is hindered by Mypy, in that you now have to remember to update this function if the api.lights and api.sensors groups ever change. It might be better to stick with the original code that uses groups, and cast as needed.

[chishm]

No worries! Thanks for working in the deconz integration, it's the first thing I ever connected HA to.

[Kane610]

No worries! Thanks for working in the deconz integration, it's the first thing I ever connected HA to.

Thanks for using it and giving back to the community!