Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add if/else automation/script action #69811

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Add if/else automation/script action #69811

merged 6 commits into from
Apr 12, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Apr 10, 2022

Proposed change

This PR adds support for an if action.
Although these constructs could already be created using the existing choose action, the choose action resembles/acts more as an switch statement.

I'm suggesting adding this construct for simplification of code and clarity. Especially with smaller conditional actions, the choose statement adds quite some overhead (and would not be the action one would think of using).

The goal is to create readable and understandable automations:

action:
  if:
    condition: state
    entity_id: light.living_room
    state: "on"
  then:
    service: light.turn_off
    entity_id: light.living_room

else case is supported too (although no practical use for this example, it does illustrate it):

action:
  if:
    condition: state
    entity_id: light.living_room
    state: "on"
  then:
    service: light.turn_off
    entity_id: light.living_room
  else:
    service: light.turn_on
    entity_id: light.living_room  

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck marked this pull request as ready for review April 12, 2022 10:18
@frenck frenck requested a review from a team as a code owner April 12, 2022 10:18
@frenck
Copy link
Member Author

frenck commented Apr 12, 2022

I think its ready to go!

@frenck frenck merged commit 67b200a into dev Apr 12, 2022
@frenck frenck deleted the frenck-2022-0851 branch April 12, 2022 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2022
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants