Improve AndroidTV typing #71036
Merged
Improve AndroidTV typing #71036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
integration: androidtv
by-code-owner
labels
|
Hey there @JeffLIrion, mind taking a look at this pull request as it has been labeled with an integration ( |
frenck
reviewed
Apr 29, 2022
| @@ -114,7 +129,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | |||
|
|
|||
| state_det_rules = entry.options.get(CONF_STATE_DETECTION_RULES) | |||
| aftv, error_message = await async_connect_androidtv( | |||
| hass, entry.data, state_detection_rules=state_det_rules | |||
| hass, dict(entry.data), state_detection_rules=state_det_rules | |||
There was a problem hiding this comment.
Just because the type MappingProxy is incompatible with the input function parameter type (dict[str, Any]).
There was a problem hiding this comment.
So maybe use Mapping[str, Any] as the typing on async_connect_androidtv for that parameter?
There was a problem hiding this comment.
But this method is also used by config_flow to test the connection based on user_input, and user_input is dict[str, Any].
There was a problem hiding this comment.
Nevermind, type Mapping[str, Any] is ok for both calls👍
MasonCrawford
approved these changes
May 1, 2022
ollo69
force-pushed
the
androidtv-improve-typing
branch
2 times, most recently
from
d6fcf61
to
a3cf54d
Compare
ollo69
force-pushed
the
androidtv-improve-typing
branch
from
a3cf54d
to
f2b3816
Compare
|
Any news on this PR? |
frenck
added
the
smash
ollo69
force-pushed
the
androidtv-improve-typing
branch
from
f2b3816
to
1d204c5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve AndroidTV
__init__andconfig_flowtypingType of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: