Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump logi_circle to 0.2.3 #71578

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

evanjd
Copy link
Contributor

@evanjd evanjd commented May 9, 2022

Proposed change

This PR bumps logi_circle to 0.2.3.

Logitech recently changed their authentication API to prevent refresh token reuse. This revealed a bug in the logi_circle API wrapper where concurrent state update requests could trigger concurrent requests to refresh the access token. If the requests finished out of order, a stale refresh token was stored and subsequent state updates would fail. This issue is resolved in 0.2.3.

Changelog at https://github.com/evanjd/python-logi-circle/releases/tag/v0.2.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title bump logi_circle to 0.2.3 Bump logi_circle to 0.2.3 May 9, 2022
@frenck frenck added this to the 2022.5.4 milestone May 9, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evanjd 👍

@frenck frenck merged commit 0842c29 into home-assistant:dev May 9, 2022
@evanjd evanjd deleted the bump-logi-circle branch May 9, 2022 12:13
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logicircle integration not working since 19/4/2022
4 participants