-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add application_credentials platform to geocaching integration #71880
Conversation
Hey there @Sholofly, @reinder83, mind taking a look at this pull request as it has been labeled with an integration ( |
It looks like that part isn't touched with this change. LGTM! Cool to see the integration is added to the new application_credentials handling. Thanks @allenporter! |
Yes, that's right, as mentioned in the description this handles the custom auth implementation similar to I was working on this for Google Calendar and it wasn't quite ready when you initially sent this PR. My impression is this is a new integration that has not hit a release yet so following up from this you may be able to stop using configuration.yaml for OAuth creds before the initial time this is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frenck and @allenporter, it's better than I could have imagined when I submitted the first PR. Awesome job. |
Doesn't this depend on the new frontend which isn't bumped in core yet? |
In this specific case: Not really, as you can't get keys. Nevertheless, the frontend part has been merged and will be in 2022.6 (Yes, I would love to see some frontend updates). |
Proposed change
Add application_credentials platform for
geocaching
integration now that it can support custom auth implementations.See new developer documentation about Custom OAuth2 Implementations
Note: This was only tested using existing config flow tests, and was not tested locally.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: