Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application_credentials platform to geocaching integration #71880

Merged
merged 3 commits into from
May 16, 2022

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented May 14, 2022

Proposed change

Add application_credentials platform for geocaching integration now that it can support custom auth implementations.

See new developer documentation about Custom OAuth2 Implementations

Note: This was only tested using existing config flow tests, and was not tested locally.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @Sholofly, @reinder83, mind taking a look at this pull request as it has been labeled with an integration (geocaching) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@reinder83
Copy link
Contributor

This integration uses an non standard oAuth flow I don't know if this will affect that, maybe @frenck or @Sholofly can check that?

@Sholofly
Copy link
Contributor

It looks like that part isn't touched with this change. LGTM!

Cool to see the integration is added to the new application_credentials handling. Thanks @allenporter!

@allenporter
Copy link
Contributor Author

Yes, that's right, as mentioned in the description this handles the custom auth implementation similar to google and a few others. The PR previously linked to an in flight docs PR but that was now merged so you can see the docs here: https://developers.home-assistant.io/docs/core/platform/application_credentials/#custom-oauth2-implementations

I was working on this for Google Calendar and it wasn't quite ready when you initially sent this PR.

My impression is this is a new integration that has not hit a release yet so following up from this you may be able to stop using configuration.yaml for OAuth creds before the initial time this is released.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works as expected.

Thanks, @allenporter 👍

image

@frenck frenck merged commit 7c68278 into home-assistant:dev May 16, 2022
@Sholofly
Copy link
Contributor

Thanks @frenck and @allenporter, it's better than I could have imagined when I submitted the first PR. Awesome job.

@MartinHjelmare
Copy link
Member

Doesn't this depend on the new frontend which isn't bumped in core yet?

@frenck
Copy link
Member

frenck commented May 16, 2022

Doesn't this depend on the new frontend which isn't bumped in core yet?

In this specific case: Not really, as you can't get keys.

Nevertheless, the frontend part has been merged and will be in 2022.6 (Yes, I would love to see some frontend updates).

@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants