-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunk large logbook queries and add an end_time to the api so we stop sending events #72351
Conversation
- I forget to mark this as frozen
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Need to run performance stats again to make sure this is no impact. Can't imagine there would be, but I need to do it anyways to revalidate the REST api and original websocket api has not regressed. |
Test failed because the CI runner is too slow 👎 |
I ended up switching to async_fire_time_changed. It is good enough for the test. Better to be reliable than perfect. |
Frontend PR home-assistant/frontend#12753
Proposed change
end_time
in the past (useful with big queries) or future (for when to cut off streaming)Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: