Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iAlarm XR integration #73083

Merged

Conversation

bigmoby
Copy link

@bigmoby bigmoby commented Jun 5, 2022

Breaking change

Removing the iAlarm XR integration under explicit Antifurto365 request. Antifurto365 claims that this integration causes several big problem in their servers and affects its business.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@gjohansson-ST gjohansson-ST mentioned this pull request Jun 6, 2022
22 tasks
@balloob
Copy link
Member

balloob commented Jun 6, 2022

Not a fan of how this is being handled. Taking the PyPI package down broke all new core installations of 2022.6. I've forked the library and put it back in #73143 to avoid a breaking change.

Please fix the merge conflicts of this PR.

Antifurto365 claims that this integration causes several big problem in their servers and affects its business.

Analytics shows 2 active installations using it…

image

@bigmoby
Copy link
Author

bigmoby commented Jun 6, 2022

Not a fan of how this is being handled. Taking the PyPI package down broke all new core installations of 2022.6. I've forked the library and put it back in #73143 to avoid a breaking change.

Please fix the merge conflicts of this PR.

Antifurto365 claims that this integration causes several big problem in their servers and affects its business.

Analytics shows 2 active installations using it…

image

I'm so sorry @balloob I'm totally agreed with you, really! But Antifurto365 is legally threatening me if I didn't delete all the code I wrote on ialarm xr. I am dismayed and I apologize, but they have left me no alternatives!

@balloob balloob merged commit 0c21bf7 into home-assistant:dev Jun 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
@bigmoby bigmoby deleted the feature/remove_ialarm_xr_integration branch May 16, 2024 09:53
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants