Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sqlalchemy lambda_stmt usage from history, logbook, and statistics #73191

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 7, 2022

Proposed change

It looks like these need a bit more time to mature upstream per
sqlalchemy/sqlalchemy#8098 (comment)
so let's rip them out any place where we need to worry
about thread safety.

There will likely be another sqlalchemy bump for
sqlalchemy/sqlalchemy#8098 in the future
as that problem seems to be more generic. Its likely that problem will
present as a raised exception failure state. All evidence suggests that
the lambdas have another undiscovered different thread safety
issue since the proposed fix there didn't solve the inconsistencies with the lambdas.

I left them in purge and the recorder thread because the problems
are thread safety issues and these queries are always single threaded
and I didn't want to risk causing a regression of #71015

While this will make the queries slower, slower and correct
is better than fast and incorrect.

Likely fixes #65499
Likely fixes #70011
Fixes #73155
Fixes #72991
Fixes #73154
Fixes #73108
Fixes Limych/ha-average#139

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (logbook) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco changed the title Remove sqlalchemy lambda_stmt usage Remove sqlalchemy lambda_stmt usage from history and statistics Jun 7, 2022
It looks like these need a bit more time to mature per
sqlalchemy/sqlalchemy#8098 (comment)
so let's rip them out for now

While this will make the queries slower, slower and correct
is better than fast and incorrect.
@bdraco bdraco changed the title Remove sqlalchemy lambda_stmt usage from history and statistics Remove sqlalchemy lambda_stmt usage from history, logbook, and statistics Jun 7, 2022
@bdraco
Copy link
Member Author

bdraco commented Jun 7, 2022

Testing

  • sqlite
  • mysql
  • postgresql

@bdraco bdraco marked this pull request as ready for review June 7, 2022 22:35
@bdraco bdraco requested a review from a team as a code owner June 7, 2022 22:35
@balloob balloob merged commit 7ae8bd5 into home-assistant:dev Jun 7, 2022
@balloob balloob mentioned this pull request Jun 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.