Add mode control for Modbus climate entities #73906
Conversation
|
Hey there @adamchengtkc, @janiversen, @vzahradnik, mind taking a look at this pull request as it has been labeled with an integration ( |
|
The idea quite good I will take a deeper look later. |
|
Documentation is on the way, will submit a PR soon. |
|
@avishorp, is it possible to also add fan mode control to modbus climate? I know the modbus component updates from time to time, and there are quite a lot users customize modbus climate to add more registers to suit for their devices. It will save the trouble for end users to update customized components along with modbus update. Thanks for your support! |
|
I will happily do that, but currently the PR is stuck, I don't know why
בתאריך יום א׳, 28 באוג׳ 2022 ב-12:16 מאת Jiagang Xu <
***@***.***>:
… @avishorp <https://github.com/avishorp>, is it possible to also add fan
mode control to modbus climate? I know the modbus component updates from
time to time, and there are quite a lot users customize modbus climate to
add more registers to suit for their devices. It will save the trouble for
end users to update customized components along with modbus update. Thanks
for your support!
—
Reply to this email directly, view it on GitHub
<#73906 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCMMTA562AMO2UHJXNNX3V3MU5PANCNFSM5ZUQZXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Waiting for review, and if you look at CI you have a doc problem. I will review it once CI is green. |
|
I have made the required doc changes (also waiting for review), how do I
link it to the feature PR?
בתאריך יום ב׳, 29 באוג׳ 2022 ב-14:27 מאת jan iversen <
***@***.***>:
… Waiting for review, and if you look at CI you have a doc problem. I will
review it once CI is green.
—
Reply to this email directly, view it on GitHub
<#73906 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCMMVLPWVNAJZ4A6LVPD3V3SNAPANCNFSM5ZUQZXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
See the PR text (Proposed change etc.), seems you have modified the template, normally it contains: Btw. you need to link this PR in the documentation PR as well. |
| @@ -87,6 +89,33 @@ def __init__( | |||
| self._attr_target_temperature_step = config[CONF_TARGET_TEMP] | |||
There was a problem hiding this comment.
Though this part remains the same, there is a question.
line 89 and line 90 have the same lvalue. Maybe line 89 should be self._attr_target_temperature = config[CONF_TARGET_TEMP]?
|
I've changed the text and added the missing lines with a link, still
getting docs-missing.
בתאריך יום ב׳, 29 באוג׳ 2022 ב-14:41 מאת jan iversen <
***@***.***>:
… See the PR text (Proposed change etc.), seems you have modified the
template, normally it contains:
## Additional information
<!--
Details are important, and help maintainers processing your PR.
Please be sure to fill out additional details, if applicable.
-->
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Btw. you need to link this PR in the documentation PR as well.
—
Reply to this email directly, view it on GitHub
<#73906 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJCMMSSYO33YC66SEUUTQ3V3SOW7ANCNFSM5ZUQZXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
frenck
added
the
smash
|
@avishorp There is a merge conflict, could you take a look? Thanks! 👍 ../Frenck |
frenck
removed
the
smash
|
Fixed the merge conflict. |
|
@frenck Any updates or concerns? does production see soon this MR ? |
|
There is a pylint error prohibiting merge, please fix. |
|
@avishorp you did a brilliant job, could you make one more fix to complete all checks, please |
|
Fixed |
Proposed change
Add support for more features for a climate entity using Modbus platform.
This PR adds the ability to configure registers to control and monitor a climate
entity's state (heat, cool, on/off, etc.)
Type of change
Additional information
This PR adds two optional configuration entries to a Modbus climate entity. The first one is
a mode register, which is used to determine the operating mode of an HVAC. An additional
set of configuration items map between the possible states and the values read/written to this
register.
The second register is an On/Off register, which enables turning a climate entity on or off (in cases
where this functionality is not provided by the mode register).
The code was tested against a Samsung air condition system, and from the documentation also seem
to be compatible with systems that are controlled by Intesis interface system which
is available for many AC brands.
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: