Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint to 2.14.4 #74192

Merged
merged 3 commits into from Jun 30, 2022
Merged

Update pylint to 2.14.4 #74192

merged 3 commits into from Jun 30, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jun 29, 2022

Proposed change

Small bugfix release.
Release notes: https://github.com/PyCQA/pylint/releases/tag/v2.14.4
Compare view: pylint-dev/pylint@v2.14.3...v2.14.4

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. But would value someone having another look at the pylint changes.

There are some changes to an exec call in the library. It is probably fine but sometimes exec has security implications.

pylint/config/config_initialization.py

@cdce8p
Copy link
Member Author

cdce8p commented Jun 29, 2022

There are some changes to an exec call in the library. It is probably fine but sometimes exec has security implications.

The exec call is used to load the init-hook which is necessary for our custom pylint plugins. It's not the best plugin structure, but it works to modify the sys.path.

core/pyproject.toml

Lines 99 to 108 in fe68c15

init-hook = """\
from pathlib import Path; \
import sys; \
from pylint.config import find_default_config_files; \
sys.path.append( \
str(Path(next(find_default_config_files())).parent.joinpath('pylint/plugins'))
) \
"""

Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure why the 3.9 test failed

Dev automation moved this from Needs review to Reviewer approved Jun 30, 2022
@cdce8p cdce8p merged commit 42d7f2a into home-assistant:dev Jun 30, 2022
Dev automation moved this from Reviewer approved to Done Jun 30, 2022
@cdce8p cdce8p deleted the pylint-2.14.4 branch June 30, 2022 06:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants