Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config flow to mystrom #74719

Merged
merged 81 commits into from
Jun 6, 2023
Merged

Add config flow to mystrom #74719

merged 81 commits into from
Jun 6, 2023

Conversation

pail23
Copy link
Contributor

@pail23 pail23 commented Jul 8, 2022

Breaking change

The YAML configuration will be deprecated.

Proposed change

Add config flow for mystrom switches and bulbs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@pail23 pail23 requested a review from fabaff as a code owner July 8, 2022 12:32
@project-bot project-bot bot added this to Needs review in Dev Jul 8, 2022
@probot-home-assistant probot-home-assistant bot added config-flow This integration migrates to the UI by adding a config flow has-tests integration: mystrom new-feature labels Jul 8, 2022
@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mystrom) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@github-actions
Copy link

github-actions bot commented Oct 9, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 9, 2022
@bdraco
Copy link
Member

bdraco commented Oct 9, 2022

Looks like there is a conflict that needs to be resolved

@github-actions github-actions bot removed the stale label Oct 9, 2022
@OneCyrus OneCyrus mentioned this pull request Oct 10, 2022
22 tasks
@github-actions
Copy link

github-actions bot commented Jan 8, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 8, 2023
@OneCyrus
Copy link

would be great if this PR doesn't die and gets a review again.

@phedoreanu
Copy link

@bdraco what about another review and a merge? 😁

homeassistant/components/mystrom/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/mystrom/translations/en.json Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Mar 22, 2023
@home-assistant home-assistant bot marked this pull request as draft March 22, 2023 14:44
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@pail23 pail23 closed this Mar 25, 2023
@pail23 pail23 marked this pull request as ready for review June 1, 2023 11:44
@home-assistant home-assistant bot requested a review from epenet June 1, 2023 11:44
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of comments have not been adressed.

@home-assistant home-assistant bot marked this pull request as draft June 1, 2023 13:16
pail23 and others added 4 commits June 1, 2023 15:24
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@pail23
Copy link
Contributor Author

pail23 commented Jun 1, 2023

@epenet I hope now I catched all your comments

@pail23 pail23 marked this pull request as ready for review June 1, 2023 14:11
@home-assistant home-assistant bot requested a review from epenet June 1, 2023 14:11
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last set of changes, then good to go.

tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
tests/components/mystrom/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 6, 2023 07:26
pail23 and others added 6 commits June 6, 2023 12:51
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@pail23 pail23 marked this pull request as ready for review June 6, 2023 11:37
@home-assistant home-assistant bot requested a review from epenet June 6, 2023 11:37
@pail23
Copy link
Contributor Author

pail23 commented Jun 6, 2023

I have merged your proposals. Many thanks for your help!

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from Review in progress to Reviewer approved Jun 6, 2023
@epenet epenet merged commit c67f32b into home-assistant:dev Jun 6, 2023
49 checks passed
Dev automation moved this from Reviewer approved to Done Jun 6, 2023
@epenet
Copy link
Contributor

epenet commented Jun 6, 2023

Aaarrgh ! just realised this is missing a documentation PR.
@pail23 can you please open the corresponding doc PR?

@pail23
Copy link
Contributor Author

pail23 commented Jun 6, 2023

@epenet I have created home-assistant/home-assistant.io#27667

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed config-flow This integration migrates to the UI by adding a config flow deprecation Indicates a breaking change to happen in the future has-tests integration: mystrom new-feature
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants