Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power sensor for MyStrom #69745

Closed
wants to merge 12 commits into from

Conversation

OneCyrus
Copy link

@OneCyrus OneCyrus commented Apr 9, 2022

Proposed change

Adds the power information from MyStrom switches as additional sensors. The power information was previously just an attribute and was removed in PR #68821

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@OneCyrus OneCyrus requested a review from fabaff as a code owner April 9, 2022 12:40
@homeassistant
Copy link
Contributor

Hi @OneCyrus,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mystrom) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@OneCyrus OneCyrus marked this pull request as draft April 11, 2022 07:13
@fabaff fabaff linked an issue Apr 13, 2022 that may be closed by this pull request
@OneCyrus OneCyrus marked this pull request as ready for review April 18, 2022 07:09
@martinfrancois
Copy link
Contributor

martinfrancois commented May 9, 2022

Any news on this one? I'm really missing support for mystrom power in home assistant...

@frenck
Copy link
Member

frenck commented May 9, 2022

@martinfrancois You can see any updates above your comment. There is no need to ask for such things. Let's keep comments on PR towards reviewing the contents of the PR itself. Thanks 馃憤

@MartinHjelmare MartinHjelmare added this to Needs review in Dev Jun 26, 2022
softplus added a commit to softplus/home-assistant.io that referenced this pull request Aug 13, 2022
Show how to use the REST API to get power & temperature for the mystrom switches. Technically it's not a part of the current integration, and should be updated once the pull request home-assistant/core#69745 is live.
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 9, 2022
@OneCyrus
Copy link
Author

waiting for PR #74719 with config flow

@github-actions github-actions bot removed the stale label Oct 10, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 12, 2023
@OneCyrus
Copy link
Author

still waiting for the upstream PR to move on.

@github-actions github-actions bot removed the stale label Jan 12, 2023
@gjohansson-ST
Copy link
Member

Setting as draft until this PR is ready

@gjohansson-ST gjohansson-ST marked this pull request as draft May 13, 2023 10:20
@ax42
Copy link

ax42 commented May 13, 2023

Am trying to replicate this functionality in NodeRed with little success -- looking forward to have it in the native plugin.

@gjohansson-ST
Copy link
Member

gjohansson-ST commented Jul 6, 2023

Config flow PR is now merged.
Please rebase this PR.

@OneCyrus
Copy link
Author

just moved the sensors to the new config flow device. I'm not sure what's the preferred way to link the sensor to the same device. Currently every sensor has it's own switch buttons but they are greyed out. Shouldn't sensors just be sensors without any buttons?

@OneCyrus OneCyrus marked this pull request as ready for review July 21, 2023 21:31
@OneCyrus
Copy link
Author

let's move on with #97024. Looks like the proper approach.

@OneCyrus OneCyrus closed this Jul 23, 2023
Dev automation moved this from Needs review to Cancelled Jul 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

Mystrom Light broken after last update to 2022.3.8 Extract mystrom switch energy attributes into sensors