Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Flo to new entity naming style #74744

Merged
merged 5 commits into from
Jul 10, 2022

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 8, 2022

Proposed change

This PR migrates the Flo integration to the new entity naming style.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @dmulcahey, mind taking a look at this pull request as it has been labeled with an integration (flo) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bachya
Copy link
Contributor Author

bachya commented Jul 8, 2022

Need to fix tests.

@dmulcahey
Copy link
Contributor

Need to fix tests.

It looks like the change causes entity ids to change. does something else need to be added for backwards compatibility?

@bachya
Copy link
Contributor Author

bachya commented Jul 8, 2022

It looks like the change causes entity ids to change. does something else need to be added for backwards compatibility?

No – this will just affect new installs of the integration.

@dmulcahey
Copy link
Contributor

Need to fix tests.

It looks like the change causes entity ids to change. does something else need to be added for backwards compatibility?

entity_id = "switch.shutoff_valve"
assert hass.states.get(entity_id).state == STATE_ON
AttributeError: 'NoneType' object has no attribute 'state'

INFO:homeassistant.helpers.entity_registry:Registered new switch.flo entity: switch.smart_water_shutoff_shutoff_valve

@dmulcahey
Copy link
Contributor

It looks like the change causes entity ids to change. does something else need to be added for backwards compatibility?

No – this will just affect new installs of the integration.

then all of the entity ids in the tests need to be adjusted.

@bachya
Copy link
Contributor Author

bachya commented Jul 8, 2022

Yep, already on it. 👍

tests/components/flo/test_binary_sensor.py Outdated Show resolved Hide resolved
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bachya 👍

@frenck frenck merged commit 5971ab6 into home-assistant:dev Jul 10, 2022
@bachya bachya deleted the flo-entity-name branch July 10, 2022 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants