Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AssertionError in RainMachine #75668

Merged
merged 1 commit into from
Jul 24, 2022
Merged

Fix AssertionError in RainMachine #75668

merged 1 commit into from
Jul 24, 2022

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 23, 2022

Proposed change

RainMachine had an unhandled AssertionError with zone runtime sensors; this PR fixes the scenario in which this can occur.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya added this to the 2022.7.7 milestone Jul 23, 2022
@bachya bachya self-assigned this Jul 23, 2022
@bachya bachya merged commit a499dfb into home-assistant:dev Jul 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2022
@bachya bachya deleted the rainmachine-fix-assertion-error branch July 25, 2022 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bachya bachya

Labels
bugfix by-code-owner cherry-picked cla-signed integration: rainmachine small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.7.7
Development

Successfully merging this pull request may close these issues.

RainMachine component: Error doing job: Task exception was never retrieved (2022.7.6)
4 participants
@bachya @bdraco @frenck @homeassistant