Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vallox bypass locking switch entity #75857

Merged
merged 11 commits into from
Nov 18, 2022

Conversation

yozik04
Copy link
Contributor

@yozik04 yozik04 commented Jul 28, 2022

Breaking change

Proposed change

Adding ventilation unit bypass locking switch

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @andre-richter, @slovdahl, @viiru-, mind taking a look at this pull request as it has been labeled with an integration (vallox) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Adding Vallox bypass locking switch entity Add Vallox bypass locking switch entity Jul 28, 2022
@yozik04 yozik04 marked this pull request as ready for review July 28, 2022 10:24
Copy link
Contributor

@slovdahl slovdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

homeassistant/components/vallox/switch.py Outdated Show resolved Hide resolved
tests/components/vallox/test_switch.py Outdated Show resolved Hide resolved
tests/components/vallox/test_switch.py Outdated Show resolved Hide resolved
yozik04 and others added 3 commits July 28, 2022 22:27
Co-authored-by: Sebastian Lövdahl <slovdahl@hibox.fi>
Co-authored-by: Andre Richter <andre-richter@users.noreply.github.com>
@yozik04
Copy link
Contributor Author

yozik04 commented Aug 17, 2022

@andre-richter @viiru- we need your reviews to move this forward.

@yozik04 yozik04 mentioned this pull request Sep 15, 2022
23 tasks
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 16, 2022
@github-actions github-actions bot removed the stale label Nov 16, 2022
@yozik04
Copy link
Contributor Author

yozik04 commented Nov 18, 2022

@MartinHjelmare What do we need to merge this? I think we have met all the requirements.

tests/components/vallox/test_switch.py Outdated Show resolved Hide resolved
tests/components/vallox/test_switch.py Outdated Show resolved Hide resolved
tests/components/vallox/test_switch.py Outdated Show resolved Hide resolved
tests/components/vallox/test_switch.py Show resolved Hide resolved
tests/components/vallox/test_switch.py Outdated Show resolved Hide resolved
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 5453b34 into home-assistant:dev Nov 18, 2022
@yozik04
Copy link
Contributor Author

yozik04 commented Nov 18, 2022

Wohhoo. Thank you, Martin!

@yozik04 yozik04 deleted the vallox_switch branch November 18, 2022 09:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants