Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EventBridge to aws integration #77573

Merged
merged 10 commits into from
Oct 25, 2022

Conversation

pghazanfari
Copy link
Contributor

@pghazanfari pghazanfari commented Aug 31, 2022

Breaking change

Proposed change

This change adds support for EventBridge for the aws integration. I am not sure if there is an existing issue, but I am looking to use this functionality in my own home assistant setup.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @pghazanfari,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@pghazanfari pghazanfari changed the title Aws eventbridge Add support for EventBridge to aws integration Aug 31, 2022
@emontnemery
Copy link
Contributor

@pghazanfari Please open a pull request to document the new functionality here: https://www.home-assistant.io/integrations/aws/
The easiest way is to just click the "Edit" link at the bottom of the page. Make sure your PR targets the "next" branch.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but please add a new test to tests/components/aws/test_init.py

pghazanfari added a commit to pghazanfari/home-assistant.io that referenced this pull request Aug 31, 2022
pghazanfari added a commit to pghazanfari/home-assistant.io that referenced this pull request Aug 31, 2022
@pghazanfari
Copy link
Contributor Author

pghazanfari commented Aug 31, 2022

@pghazanfari Please open a pull request to document the new functionality here: https://www.home-assistant.io/integrations/aws/ The easiest way is to just click the "Edit" link at the bottom of the page. Make sure your PR targets the "next" branch.

I've added this pull request to update the documentation: home-assistant/home-assistant.io#23963

@pghazanfari
Copy link
Contributor Author

Looks good overall, but please add a new test to tests/components/aws/test_init.py

Unit tests have been added.

pghazanfari added a commit to pghazanfari/home-assistant.io that referenced this pull request Aug 31, 2022
@pghazanfari
Copy link
Contributor Author

pghazanfari commented Sep 2, 2022

@emontnemery Would you be able to merge my commit since it passes all the checks?

@github-actions
Copy link

github-actions bot commented Oct 2, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 2, 2022
@emontnemery
Copy link
Contributor

@pghazanfari the PR now has commits from two user accounts which makes the CLA check fail, can you please clean that up?

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pghazanfari 👍

@emontnemery
Copy link
Contributor

OK to merge when the CLA error has been fixed.

@pghazanfari
Copy link
Contributor Author

OK to merge when the CLA error has been fixed.

I think it should be fixed now. I added the email address to my account.

@emontnemery emontnemery merged commit dbfca8d into home-assistant:dev Oct 25, 2022
@home-assistant home-assistant deleted a comment from homeassistant Oct 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants