-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EventBridge to aws integration #77573
Conversation
Hi @pghazanfari, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
@pghazanfari Please open a pull request to document the new functionality here: https://www.home-assistant.io/integrations/aws/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, but please add a new test to tests/components/aws/test_init.py
… for EventBridge AWS integration
…-assistant-core into aws-eventbridge
Reference implementation: home-assistant/core#77573
Reference implementation: home-assistant/core#77573
I've added this pull request to update the documentation: home-assistant/home-assistant.io#23963 |
Unit tests have been added. |
Reference pull request: home-assistant/core#77573
@emontnemery Would you be able to merge my commit since it passes all the checks? |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
@pghazanfari the PR now has commits from two user accounts which makes the CLA check fail, can you please clean that up? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @pghazanfari 👍
OK to merge when the CLA error has been fixed. |
I think it should be fixed now. I added the email address to my account. |
Breaking change
Proposed change
This change adds support for EventBridge for the aws integration. I am not sure if there is an existing issue, but I am looking to use this functionality in my own home assistant setup.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: