Improve type hints in trace #78366
Merged
Improve type hints in trace #78366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
integration: trace
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
25 tasks
epenet
commented
Sep 13, 2022
Comment on lines
+222
to
+223
| config: dict[str, Any] | None, | ||
| blueprint_inputs: dict[str, Any] | None, |
There was a problem hiding this comment.
I've enabled None here for config and blueprint_inputs
I couldn't find a reason for them to be compulsory, and it helps with #78368
| @@ -239,7 +241,7 @@ def __init__( | |||
| trace_set_child_id(self.key, self.run_id) | |||
| trace_id_set((self.key, self.run_id)) | |||
|
|
|||
| def set_trace(self, trace: dict[str, deque[TraceElement]]) -> None: | |||
| def set_trace(self, trace: dict[str, deque[TraceElement]] | None) -> None: | |||
There was a problem hiding this comment.
I've enabled None here for trace
Since self._trace is already set to be optional, I think this should be OK and it helps with #78368
balloob
approved these changes
Sep 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Improve type hints in trace
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: