Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach search about blueprints #78535

Merged
merged 1 commit into from May 30, 2023
Merged

Teach search about blueprints #78535

merged 1 commit into from May 30, 2023

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Sep 15, 2022

Proposed change

Teach search about blueprints. This is a follow-up to #78444 which blocks attempts to delete a blueprint which is in use.

Note: This needs a frontend PR to add links from blueprints to automations and scripts using it

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (script) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (search) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (automation) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Sep 26, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Sep 28, 2022
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 24, 2022
@frenck frenck marked this pull request as draft March 5, 2023 19:43
@frenck
Copy link
Member

frenck commented Mar 5, 2023

Marking this one as draft, until there is a frontend.

@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Mar 5, 2023
@bramkragten bramkragten marked this pull request as ready for review May 26, 2023 13:54
@bramkragten bramkragten merged commit d05d674 into dev May 30, 2023
51 of 52 checks passed
@bramkragten bramkragten deleted the search_blueprints branch May 30, 2023 13:04
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants