Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Related blueprints #16618

Merged
merged 9 commits into from
May 30, 2023
Merged

Related blueprints #16618

merged 9 commits into from
May 30, 2023

Conversation

bramkragten
Copy link
Member

@bramkragten bramkragten commented May 24, 2023

Proposed change

Needs: home-assistant/core#78535

  • Allows to see all the automations/scripts that are using a certain blueprint
  • Add the used blueprint to related items of the script/automation
  • Lists the automations/scripts that prevent a blueprint from being deleted

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

blueprint.path
);
if (related.automation?.length || related.script?.length) {
showAlertDialog(this, {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ask the user if we should delete all scripts/automations that use the blueprint for them? Seems a bit scary...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could ask if Home Assistant should keep and convert or delete the scripts/automations. For example in a dialog with radio buttons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert? What do you mean with that?

@bramkragten bramkragten marked this pull request as ready for review May 26, 2023 14:35
@bramkragten
Copy link
Member Author

bramkragten commented May 29, 2023

In a follow up PR I'll convert the blueprints datatable to use an overflow like the automations/scripts one

Added

@bramkragten bramkragten merged commit a70d7d8 into dev May 30, 2023
8 checks passed
@bramkragten bramkragten deleted the related-blueprints branch May 30, 2023 13:04
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants