Migrate attributes to sensors in Litter-Robot #78580
Conversation
probot-home-assistant
bot
added
deprecation
|
Hey there @natekspencer, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
LGTM and was one of the next items on the list to tackle! The documentation will need to be updated to reflect the changes. Also, the next release of pylitterbot will include power status for the feeder robot as well. We'll want to add that here when the dependency gets bumped.
| Robot: ( | ||
| RobotBinarySensorEntityDescription[Robot]( | ||
| key="power_status", | ||
| name="Power status", |
There was a problem hiding this comment.
Is this plugged in? Can we make this Charging?
There was a problem hiding this comment.
I'm not sure charging is the right concept for this. The unit is primarily mains powered and doesn't include a backup battery by default (except, I think, on the feeder robot). And nothing in the "API" indicates whether a battery is actually installed. So most of the time it's simply just "AC" in the data to indicate it's powered.
There was a problem hiding this comment.
Why does it even exist if it has no battery 😬
There was a problem hiding this comment.
It's powered on or it's unavailable ?
There was a problem hiding this comment.
Clarification, a battery isn't included by default, but you can buy one and install it so that it continues to function during power outages. I've installed one in all of my units. So then it comes back as "AC", "DC" or "NC" (not connected).
| @@ -33,6 +36,21 @@ def get_platforms_for_robots(robots: list[Robot]) -> set[Platform]: | |||
| } | |||
|
|
|||
|
|
|||
| async def async_setup(hass: HomeAssistant, config: ConfigType) -> bool: | |||
| """Set up the Litter-Robot integration.""" | |||
| async_create_issue( | |||
There was a problem hiding this comment.
Please remove this repairs issue. We don't know that there's any issue as we don't know that the user is using the deprecated attributes.
Breaking change
The vacuum entity attributes in the Litter-Robot integration are now available as diagnostic sensors.
Please adjust any automations or scripts you may have that use these attributes.
Proposed change
Migrate attributes to sensors in Litter-Robot
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: