Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text platform #79454

Merged
merged 26 commits into from
Nov 24, 2022
Merged

Add text platform #79454

merged 26 commits into from
Nov 24, 2022

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Oct 2, 2022

Proposed change

Adds a new text platform. See home-assistant/architecture#812 for summary

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (demo) you are listed as a code owner for? Thanks!

@raman325 raman325 marked this pull request as ready for review October 7, 2022 05:43
@raman325 raman325 requested a review from a team as a code owner October 7, 2022 05:43
@raman325 raman325 marked this pull request as draft October 7, 2022 14:33
@raman325 raman325 marked this pull request as ready for review November 17, 2022 19:10
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Let's make sure it is strictly typed from the get-go

homeassistant/components/text/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Show resolved Hide resolved
homeassistant/components/text/__init__.py Show resolved Hide resolved
homeassistant/components/text/__init__.py Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
raman325 and others added 3 commits November 21, 2022 13:26
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
raman325 added a commit to raman325/home-assistant that referenced this pull request Nov 21, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a single comment, but it applies to other too. Shorthand attrs win over entity descriptions, the current PR has that the other way around.

homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
raman325 added a commit to raman325/home-assistant that referenced this pull request Nov 23, 2022
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/text/__init__.py Outdated Show resolved Hide resolved
@frenck
Copy link
Member

frenck commented Nov 24, 2022

Created a PR for the frontend here: home-assistant/frontend#14447

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now 👍

Thanks @raman325 🥇

../Frenck

@frenck frenck merged commit 003e422 into home-assistant:dev Nov 24, 2022
@raman325 raman325 deleted the text branch November 24, 2022 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants