-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate common statistics DB schema errors on start #79707
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
ec3cfc5
to
b37dc67
Compare
Set to draft until tests have been added |
c104140
to
aec43e6
Compare
aec43e6
to
914f843
Compare
914f843
to
d9ccc20
Compare
|
||
if "statistics_meta.4-byte UTF-8" in schema_errors: | ||
# Attempt to convert the table to utf8mb4 | ||
_LOGGER.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a notification ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I guess the frontend is not loaded yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could however create a repair issue
Proposed change
Validate and repair common recorder database schema errors of the statistics tables, which are caused by incorrectly restoring or migrating tables between database engines:
Tested with the following SQL script on a MariaDB database:
On startup, Home Assistant should report:
Ather startup, the modified tables and column should be changed back to the correct settings.
Validating the
events
andstates
tables will be done in follow-up PRsType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: