Modbus: Add support for Holding Registers to Binary Sensor

[Nippey]

Breaking change

Proposed change

I have a 32-channel input ("N4DIM32") for modbus. This device exposes its internal states via holding registers.
(If required, I can attach the interface description provided by the seller.)
As binary_sensor currently only supports CALL_TYPE_COIL, CALL_TYPE_DISCRETE:

ADDED: Support for CALL_TYPE_REGISTER_HOLDING.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Modbus: Add support for Holding Registers to Binary Sensor home-assistant.io#24595
• Community link: https://community.home-assistant.io/t/modbus-binary-sensor-cannnot-read-from-holding-register/474938

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hi Nippey

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[home-assistant]

Hey there @adamchengtkc, @janiversen, @vzahradnik, mind taking a look at this pull request as it has been labeled with an integration (modbus) you are listed as a code owner for? Thanks!

[janiversen]

Will take a look later.

[janiversen]

Test are missing, please amend the relevant test_file with tests that control the new functionality.

[janiversen]

Please solve the pylint/flake8 warnings.

[Nippey]

Thanks for the heads-up!
Removed CALL_TYPE_REGISTER_HOLDING, as not implicitly used.

[Nippey]

Test are missing, please amend the relevant test_file with tests that control the new functionality.

I just found and checked the test file.
It left me rather confused.
Sorry, I will need some time to understand the structure 🙈

[Nippey]

@janiversen:
I think I got it.
But I am not sure, if this is already all, the test should be doing.

[janiversen]

All good apart from the CI error in isort, please solve.

[Nippey]

Sorry, tried to rename the branch to something more meaningful.
But this closed the pull-request.
Keeping "patch-1".

Solved 'isort' error.

[janiversen]

LGTM.