Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update modbus.markdown #24594

Closed
wants to merge 118 commits into from
Closed

Update modbus.markdown #24594

wants to merge 118 commits into from

Conversation

Nippey
Copy link
Contributor

@Nippey Nippey commented Oct 17, 2022

Update binary sensor to accept holding registers as input type

Proposed change

I have a 32-channel input ("N4DIM32") for modbus. This device exposes its internal states via holding registers.
(If required, I can attach the interface description provided by the seller.)
As binary_sensor currently only supports CALL_TYPE_COIL, CALL_TYPE_DISCRETE:
ADDED: Support for CALL_TYPE_REGISTER_HOLDING.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

bdraco and others added 30 commits September 7, 2022 12:53
@bdraco
Tweak bluetooth release notes (home-assistant#24032)
d899cfa
@frenck
Merge branch 'next' into rc
3f6edf7
@frenck
Merge branch 'next' into rc
270d3de
@frenck
Merge branch 'next' into rc
4f822b2
@frenck
2022.10: Beta release notes
a01e2d9
@frenck
2022.10: Small fixes
0993310
@frenck
Merge branch 'current' into rc
b4022f6
@elupus @frenck
Add documentation for initial nibe implementation (home-assistant#24141)
41e20db 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@piitaya @frenck
Add subview documentation (home-assistant#24277)
1184dac
@krazos @frenck
Add additional known working iBeacon devices (home-assistant#24284)
a17baaa
@frenck
2022.10: Update post date
0113904
@frenck
2022.10: Finish breaking changes section
fb44fa5
@frenck
2022.10: Update changelog
fd8a7b7
@frenck
2022.10: Update dev blog links
2eaddf0
@frenck
Devcontainer improvements (home-assistant#24356)
f00ab82
@frenck
2022.10: Add section about Marcel
b3c812a
@frenck
2022.10: Active bluetooth connections
57784cf
@frenck
2022.10: Finding integrations
e576370
@frenck
2022.10: iBeacons
9f6566d
@frenck
2022.10: New styled dialogs
3fee782
@frenck
2022.10: View YAML automations in UI editor
582990e
@frenck
2022.10: Other noteworthy
fe94edd
@frenck
2022.10: Version template function
d1c66c9
@frenck
2022.10: Google Sheets
cb7d0c1
@frenck
2022.10: Subviews
2b11534
@frenck
2022.10: Add Google Sheets screenshot
2faf7d5
@frenck
2022.10: Intro and tweaks
196036f
@frenck
2022.10: Better Google Sheets screenshot
0b31119
@frenck
2022.10: Even better Google Sheets screenshot
9efb6d3
@balloob @zsarnett @ludeeus
Add SkyConnect landing page (home-assistant#24389)
147c5fb 
* SkyConnect landing page

* Inches

* Final tweaks

* Update source/skyconnect/index.html

Co-authored-by: Joakim Sørensen <joasoe@gmail.com>

Co-authored-by: Zack Barett <zackbarett@hey.com>
Co-authored-by: Joakim Sørensen <joasoe@gmail.com>
@home-assistant home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Oct 17, 2022
@home-assistant home-assistant bot added the next This PR goes into the next branch label Oct 17, 2022
@Nippey
Copy link
Contributor Author

Nippey commented Oct 17, 2022

I think I messed up. I will redo on "next".

@Nippey Nippey closed this Oct 17, 2022
@home-assistant home-assistant bot removed in-progress This PR/Issue is currently being worked on Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janiversen janiversen Awaiting requested review from janiversen janiversen is a code owner

@dmulcahey dmulcahey Awaiting requested review from dmulcahey dmulcahey is a code owner

@Adminiuga Adminiuga Awaiting requested review from Adminiuga Adminiuga is a code owner

@puddly puddly Awaiting requested review from puddly puddly is a code owner

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

@Jc2k Jc2k Awaiting requested review from Jc2k Jc2k is a code owner

@Ernst79 Ernst79 Awaiting requested review from Ernst79 Ernst79 is a code owner

@fabaff fabaff Awaiting requested review from fabaff fabaff is a code owner

@StevenLooman StevenLooman Awaiting requested review from StevenLooman StevenLooman is a code owner

@pvizeli pvizeli Awaiting requested review from pvizeli

@rytilahti rytilahti Awaiting requested review from rytilahti rytilahti is a code owner

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

@andrewsayre andrewsayre Awaiting requested review from andrewsayre andrewsayre is a code owner

@raman325 raman325 Awaiting requested review from raman325 raman325 is a code owner

@balloob balloob Awaiting requested review from balloob balloob is a code owner

@bieniu bieniu Awaiting requested review from bieniu bieniu is a code owner

@thecode thecode Awaiting requested review from thecode thecode is a code owner

@chemelli74 chemelli74 Awaiting requested review from chemelli74 chemelli74 is a code owner

@andrey-git andrey-git Awaiting requested review from andrey-git andrey-git is a code owner

@bachya bachya Awaiting requested review from bachya bachya is a code owner

@azogue azogue Awaiting requested review from azogue azogue is a code owner

@cgtobi cgtobi Awaiting requested review from cgtobi cgtobi is a code owner

@allenporter allenporter Awaiting requested review from allenporter allenporter is a code owner

@emontnemery emontnemery Awaiting requested review from emontnemery emontnemery is a code owner

@hunterjm hunterjm Awaiting requested review from hunterjm hunterjm is a code owner

@robbiet480 robbiet480 Awaiting requested review from robbiet480 robbiet480 is a code owner

@frenck frenck Awaiting requested review from frenck frenck is a code owner

@farmio farmio Awaiting requested review from farmio farmio is a code owner

@marvin-w marvin-w Awaiting requested review from marvin-w marvin-w is a code owner

@teharris1 teharris1 Awaiting requested review from teharris1 teharris1 is a code owner

@marcelveldt marcelveldt Awaiting requested review from marcelveldt marcelveldt is a code owner

@ludeeus ludeeus Awaiting requested review from ludeeus ludeeus is a code owner

@klaasnicolaas klaasnicolaas Awaiting requested review from klaasnicolaas klaasnicolaas is a code owner

Assignees
No one assigned
Labels
has-parent This PR has a parent PR in a other repo next This PR goes into the next branch
Projects
Documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet