Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MQTT type hints part 1 #80523

Merged
merged 7 commits into from
Nov 2, 2022
Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Oct 18, 2022

Proposed change

Improve type annotation part for MQTT modules:

  • alarm_control_panel
  • binary_sensor
  • button

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

@jbouwh
Copy link
Contributor Author

jbouwh commented Oct 18, 2022

@epenet may be you like to have a look at these PR's. A second one is ready too: #80529

@jbouwh jbouwh changed the title Improve MQTT type annotation part 1 Improve MQTT type hints part 1 Oct 20, 2022
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments for __init__.py
For the platforms, it's harder to review because mixin.py is not typed.
Maybe that should be a preliminary PR?

homeassistant/components/mqtt/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/mqtt/__init__.py Outdated Show resolved Hide resolved
@jbouwh jbouwh force-pushed the mqtt-typing branch 2 times, most recently from 2d1997e to 021ce69 Compare October 20, 2022 14:23
@jbouwh jbouwh marked this pull request as draft October 24, 2022 12:29
@jbouwh jbouwh marked this pull request as ready for review October 24, 2022 13:15
@jbouwh jbouwh marked this pull request as draft October 24, 2022 17:55
@jbouwh jbouwh force-pushed the mqtt-typing branch 2 times, most recently from 81dda20 to 3364979 Compare October 24, 2022 21:20
@jbouwh jbouwh marked this pull request as ready for review October 25, 2022 08:01
@jbouwh
Copy link
Contributor Author

jbouwh commented Oct 25, 2022

This PR is a follow up on: #80913

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if tests pass

@jbouwh jbouwh merged commit b4ad037 into home-assistant:dev Nov 2, 2022
@jbouwh jbouwh deleted the mqtt-typing branch November 2, 2022 19:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants