Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics to bsblan #80957

Merged
merged 5 commits into from Nov 26, 2022
Merged

Conversation

liudger
Copy link
Contributor

@liudger liudger commented Oct 25, 2022

Breaking change

Proposed change

Add diagnostics to BSB-Lan integration this pull request depends on #80956

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title add diagnostics to bsblan Add diagnostics to bsblan Oct 25, 2022
@liudger liudger marked this pull request as ready for review October 26, 2022 09:31
tests/components/bsblan/test_diagnostics.py Outdated Show resolved Hide resolved
tests/components/bsblan/test_diagnostics.py Outdated Show resolved Hide resolved
@frenck
Copy link
Member

frenck commented Nov 17, 2022

@liudger Something went wrong, there are all kinds of unrelated commits in this PR. Could you take a look and clean it up?

Thanks! 👍

../Frenck

@liudger
Copy link
Contributor Author

liudger commented Nov 18, 2022

@liudger Something went wrong, there are all kinds of unrelated commits in this PR. Could you take a look and clean it up?

Thanks! 👍

../Frenck

@frenck Not sure what I did wrong, probably forgot to force push. Thanks for the heads-up 👍

WJ

Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @liudger!

@rytilahti rytilahti merged commit fb132f8 into home-assistant:dev Nov 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2022
@liudger liudger deleted the add_support_diagnostics branch November 30, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants