Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle sending ZCL commands with empty bitmap options #81051

Merged

Conversation

puddly
Copy link
Contributor

@puddly puddly commented Oct 27, 2022

Proposed change

ZHA fails to send commands that include empty bitfields:

2022-10-26 20:32:37.243 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection] [140024940356912] reduce() of empty iterable with no initial value
Traceback (most recent call last):
  File "/opt/homeassistant/homeassistant/components/websocket_api/commands.py", line 200, in handle_call_service
    await hass.services.async_call(
  File "/opt/homeassistant/homeassistant/core.py", line 1744, in async_call
    task.result()
  File "/opt/homeassistant/homeassistant/core.py", line 1781, in _execute_service
    await cast(Callable[[ServiceCall], Awaitable[None]], handler.job.target)(
  File "/opt/homeassistant/homeassistant/helpers/service.py", line 748, in admin_handler
    await result
  File "/opt/homeassistant/homeassistant/components/zha/api.py", line 1324, in issue_zigbee_cluster_command
    await zha_device.issue_cluster_command(
  File "/opt/homeassistant/homeassistant/components/zha/core/device.py", line 704, in issue_cluster_command
    **convert_to_zcl_values(params, commands[command].schema)
  File "/opt/homeassistant/homeassistant/components/zha/core/helpers.py", line 169, in convert_to_zcl_values
    functools.reduce(
TypeError: reduce() of empty iterable with no initial value

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zha can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant unassign zha Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dmulcahey dmulcahey added this to the 2022.11.0 milestone Oct 27, 2022
@dmulcahey dmulcahey merged commit b8edc86 into home-assistant:dev Oct 27, 2022
balloob pushed a commit that referenced this pull request Oct 27, 2022
Handle sending commands with empty bitmaps
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants