Ignore unspecified addresses from zeroconf #81620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices include 0.0.0.0 in their addresses. We need to ignore these addresses as they are invalid see issue home-assistant#81590 (A seperate fix for homekit_controller will come in another PR)
home-assistant
bot
added
bugfix
cla-signed
has-tests
integration: zeroconf
small-pr
Rudd-O
suggested changes
Nov 7, 2022
| @@ -552,12 +552,20 @@ def _first_non_link_local_address( | |||
| """Return the first ipv6 or non-link local ipv4 address, preferring IPv4.""" | |||
| for address in addresses: | |||
| ip_addr = ip_address(address) | |||
| if not ip_addr.is_link_local and ip_addr.version == 4: | |||
| if ( | |||
| not ip_addr.is_link_local | |||
There was a problem hiding this comment.
Why are we ignoring link-local addresses? That's a valid IP address in the context of discovering stuff in the LAN.
There was a problem hiding this comment.
This code only orders the ip addresses to present the one we can most likely connect to first. All of them are still accessible as addresses
There was a problem hiding this comment.
OK. First non link local address. Understood.
Rudd-O
approved these changes
Nov 7, 2022
| @@ -552,12 +552,20 @@ def _first_non_link_local_address( | |||
| """Return the first ipv6 or non-link local ipv4 address, preferring IPv4.""" | |||
| for address in addresses: | |||
| ip_addr = ip_address(address) | |||
| if not ip_addr.is_link_local and ip_addr.version == 4: | |||
| if ( | |||
| not ip_addr.is_link_local | |||
There was a problem hiding this comment.
OK. First non link local address. Understood.
bachya
approved these changes
Nov 7, 2022
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Some devices include 0.0.0.0 in their addresses. We need to ignore these addresses as they are invalid
see issue #81590 (A seperate fix for homekit_controller is in #81621)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: