Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) in Overkiz integration #81743

Closed

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Nov 7, 2022

Proposed change

Add support for the HitachiAirToAirHeatPump (hlrrwifi:HLinkMainController) climate entity, ported from
https://github.com/iMicknl/ha-tahoma/blob/master/custom_components/tahoma/climate_devices/hitachi_air_to_air_heat_pump.py.

Fixes #85781

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2022

Hey there @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the issue, add the integration domain after the command.

@iMicknl iMicknl marked this pull request as draft November 7, 2022 20:15
@iMicknl
Copy link
Contributor Author

iMicknl commented Nov 7, 2022

Marking as draft, since I want to first test this with a user that has the HLRRWIFI version and a user that has the OVP version. Hopefully we can simplify the code a bit, but I worry, since this device is very complex.

Copy link
Contributor

@nyroDev nyroDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small review IMHO, not sure about the real usage for this device though...

@Quentame
Copy link
Member

Is this PR ready for review ?

@iMicknl
Copy link
Contributor Author

iMicknl commented Nov 19, 2022

Is this PR ready for review ?

No sorry, I had a more extensive look and both products have more differences than I thought at a first glance. I will mark it ready for review on GitHub when I am done, but unfortunately it is more work than expected.

Yay for standardization on the Overkiz side. 🥲

@iMicknl iMicknl force-pushed the overkiz/hitachi_air_heat_pump branch from 82325fc to 3640301 Compare March 1, 2023 19:01
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 4, 2023
@iMicknl
Copy link
Contributor Author

iMicknl commented Jul 4, 2023

Superseded by #95706

@iMicknl iMicknl closed this Jul 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants